Perl::Critic::Policy::InputOutput::ProhibitOneArgSelect − Never write "select($fh)".
This Policy is part of the core Perl::Critic distribution.
Conway discourages the use of a raw select() when setting autoflushes. We'll extend that further by simply prohibiting the one−argument form of select() entirely; if you really need it you should know when/where/why that is. For performing autoflushes, Conway recommends the use of "IO::Handle" instead.
select((select($fh),
$|=1)[0]); # not ok
select $fh; # not ok
use IO::Handle;
$fh−>autoflush(); # ok
*STDOUT−>autoflush(); # ok
This Policy is not configurable except for the standard options.
IO::Handle.
Graham TerMarsch <[email protected]>
Copyright (c) 2005−2011 Graham TerMarsch. All rights reserved.
This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself.